• gopher: null or undefined error

    From Nigel Reed@VERT to GitLab issue in main/sbbs on Sunday, August 10, 2025 22:27:09
    open https://gitlab.synchro.net/main/sbbs/-/issues/964

    Just spotting this in my error log:

    ```
    srvc 0042 Gopher <Guest> !JavaScript /sbbs/exec/gopherservice.js line 173: Error: Argument #1 is an unexpected 'null' or 'undefined' value
    ```

    This is the corresponding log entry:

    Aug 2 06:46:09 bbs synchronet: srvc 0042 Gopher client request: 'nodelist'

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 11:19:32
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7513

    What's on line 173 of your gopherservice.js file?

    For me (and Git) it's:
    `write("\r\n");`

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 12:09:26
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7514

    Oh, I forgot I added 4 lines of text. (See #946).

    write(u.alias + " (" + u.age + " " + u.gender +") ");

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 12:19:48
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7516

    That doesn't look like an argument that evaulate to null or undefined. If you remove the lines you added, do you still get the same error?

    Sharing your entire modified script (or a diff against the original) might be helpful.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 12:51:02
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7517

    ```
    $ diff ~/sbbs-git/exec/gopherservice.js gopherservice.js
    92a93,96
    writeln("0Due to abuse, tor exit nodes, when discovered, will be blocked.");
    writeln("0Also, gopher proxies that allow search engines and users through");
    writeln("0unchecked will also be blocked. Download a gopher client and run");
    writeln("0it on your own system to avoid disruption to service.");
    ```

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 13:45:46
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7518

    By my counting insert 4 lines makes line 173 this: `write(format(NodeAction[system.node_list[n].action],system.node_list[n].aux));`

    Which implies an issue with the `NodeAction[]` not including the listed node's `action` value, likely `NODE_CUSTOM`.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 15:58:30
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7521

    Should be now fixed.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 16:37:46
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7525

    Cheers. I'm not sure how I would test it since I'm not sure what caused it but I'll keep an eye out.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 16:41:51
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7527

    The trigger would be a gopher request for the node_list while one or more nodes is executing your "custom action" - whatever that is.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 16:44:57
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7528

    the root problem was that gopherservice.js was never updated (before now) support custom node actions. So if you had one, and a node was performing that "action" while someone requested the node list via Gopher, you'd get that error.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 16:45:13
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7528

    the root problem was that gopherservice.js was never updated (before now) to support custom node actions. So if you had one, and a node was performing that "action" while someone requested the node list via Gopher, you'd get that error.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Monday, August 11, 2025 17:35:26
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7530

    Ah ok. That makes sense. I should be able to try to duplicate the issue then though I am sure it's properly fixed. Thanks.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab issue in main/sbbs on Saturday, August 16, 2025 15:15:05
    close https://gitlab.synchro.net/main/sbbs/-/issues/964

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Saturday, August 16, 2025 15:15:06
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7537

    Pretty sure this is addressed, so closing. Please reopen if you see it again.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab issue in main/sbbs on Monday, August 18, 2025 12:34:49
    reopen https://gitlab.synchro.net/main/sbbs/-/issues/964

    Just spotting this in my error log:

    ```
    srvc 0042 Gopher <Guest> !JavaScript /sbbs/exec/gopherservice.js line 173: Error: Argument #1 is an unexpected 'null' or 'undefined' value
    ```

    This is the corresponding log entry:

    Aug 2 06:46:09 bbs synchronet: srvc 0042 Gopher client request: 'nodelist'

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Monday, August 18, 2025 12:34:49
    https://gitlab.synchro.net/main/sbbs/-/issues/964#note_7552

    Using a custom node activity while in MRC I tried to access gopher and it worked fine. No error so confirming the fix works.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net